Skip to content

fixed #12264 - auto-detection of Python in Visual Studio built binaries when python3.exe does not exist - #5765

Merged
chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
firewave:py-auto-win
Dec 15, 2023
Merged

fixed #12264 - auto-detection of Python in Visual Studio built binaries when python3.exe does not exist#5765
chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
firewave:py-auto-win

Conversation

@firewave

Copy link
Copy Markdown
Collaborator

I also suppressed the unwanted output from the system().

@firewave

Copy link
Copy Markdown
Collaborator Author

I cannot think of an easy way to unit test this right now.

I tested it locally by replacing the binaries to look for with python4.exe and python3.exe.

@danmar

danmar commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

I cannot think of an easy way to unit test this right now.

me neither. I thought about it too.

@danmar danmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github
chrchr-github merged commit c79ec60 into cppcheck-opensource:main Dec 15, 2023
@firewave
firewave deleted the py-auto-win branch December 15, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants